Improve title on accordion label #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/lumino
that referenced
this pull request
Sep 14, 2022
fcollonval
added a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
|
For those of us following along on the repo: What issue does this fix? Why is it important to have the title fall back to the label if the caption is not present? Please make some notes in either the PR or the commit so that the rest of us can understand what is going on, or if someone in the future is wondering why this change was made, they can understand. |
fcollonval
added a commit
to fcollonval/benchmarks
that referenced
this pull request
Sep 19, 2022
fcollonval
added a commit
to jupyterlab/benchmarks
that referenced
this pull request
Sep 22, 2022
* Fix command to run memory-leak test * Acknowledge confirmation dialog * Support new tab selector following jupyterlab/lumino#406 * Add timeout to let Plotly figures resize * Skip motion for now as it is not a motion but a delete + insert action
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label may be truncated in the UI if it is too long due to CSS styling. The title is expected to be the fallback to the full information in such case.