Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow on to #411 addressing yield* #415

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Follow on to #411 addressing yield* #415

merged 3 commits into from
Sep 15, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Sep 15, 2022 •
edited
Loading

This PR:

  • adds a section in the migration guide for yield* usage
  • un-deprecates empty()

cc: @vidartf, you might find this and #411 interesting

@afshin afshin added documentation Improvements or additions to documentation maintenance Dependencies, build, technical debt, etc. labels Sep 15, 2022
@afshin afshin added this to the Lumino 2 milestone Sep 15, 2022
@afshin afshin changed the title Add a section in the migration guide for yield* usage, un-deprecate empty() Follow on to #411 addressing yield* Sep 15, 2022
@afshin afshin force-pushed the yield-star branch 3 times, most recently from b6a0afd to 49d0c4a Compare September 15, 2022 10:30
fcollonval
fcollonval approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit 4b159d2 into jupyterlab:main Sep 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels
documentation Improvements or additions to documentation maintenance Dependencies, build, technical debt, etc.
Projects
No open projects
Lumino 2
Status: done
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.
2 participants
@afshin @fcollonval