Datagrid: Do not prevent page scroll if we are not actually scrolling the grid #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fcollonval I think this change is missing from yesterday's release? |
|
@ibdafna Monday release was targeting 1.x not 2.x. Is this PR for 1.x too? As I did not follow closely the changes may for Lumino 2 on the datagrid and the milestone was not set I did not backport it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Datagrid was always preventing the propagation of the wheel event, preventing the scrolling of the page when using the wheel on top of a grid that does not need scrolling. This PR fixes it by only stopping the propagation if the grid actually needs scrolling.
cc. @ibdafna
scrolling.mp4