-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable text eliding by default #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ibdafna could you run yarn api
to make the CI check happy 😉 ?
Does it solves the issue or should we let the issue opened?
I would say that this does not fix the issue, since we can make vast algorithmic improvements (and even keep eliding enabled by default if we do that). While, it certainly helps to be able to disable eliding, ideally it could be disabled/enabled on per-column basis. |
@krassowski This is a good start, and it does address the issue. We can open separate PRs for improving the algorithms of text eliding and wrapping. But I'd like to iterate again, there is no easy way to significantly reduce the time elide takes as it needs to make at least one call per cell to the measureText function. You can certainly enable or disable this on a per column basis by setting a custom TextRenderer for columns you want it enabled or disabled for. |
@fcollonval |
I don't know if you did cacc6ac manually then (thanks for that). But I think the remaining error was a typo in that commit. I fixed it. 🤞 for the CI |
Addresses #448