Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag-and-drop of nested dock panel #473

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Fix drag-and-drop of nested dock panel #473

merged 4 commits into from
Nov 28, 2022

Conversation

drcd1
Copy link
Contributor

@drcd1 drcd1 commented Nov 23, 2022

This pull request applies the proposed solution to issue #472, by allowing drag events to be propagated when the current potential docking position is invalid.

Here you can see an animation of the solved problem.
Animation2

@welcome
Copy link

welcome bot commented Nov 23, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval added the bug Something isn't working label Nov 25, 2022
@fcollonval fcollonval added this to the 1.x milestone Nov 25, 2022
fcollonval
fcollonval reviewed Nov 25, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @drcd1

Would you mind adding your example in the examples folder as part of this PR (you may call it example-nested-dockpanel)

fcollonval
fcollonval requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example.

I have a tiny change request and we are good to go for me.

examples/example-nested-dockpanel-amd/README.md Outdated Show resolved Hide resolved
@fcollonval fcollonval changed the title Fix issue #472 Fix drag-and-drop of nested dock panel Nov 28, 2022
@drcd1 @fcollonval
Update examples/example-nested-dockpanel-amd/README.md
78b14a3 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fcollonval
fcollonval approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drcd1

@fcollonval fcollonval merged commit 8fe77cd into jupyterlab:main Nov 28, 2022
@welcome
Copy link

welcome bot commented Nov 28, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval
Copy link
Member

@meeseeksdev please backport to 1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Nov 28, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/lumino that referenced this pull request Nov 28, 2022
@drcd1 @meeseeksmachine
Backport PR jupyterlab#473: Fix drag-and-drop of nested dock panel
c985176
fcollonval pushed a commit that referenced this pull request Nov 28, 2022
@meeseeksmachine @drcd1
Backport PR #473: Fix drag-and-drop of nested dock panel (#475)
db347a2 
Co-authored-by: Duarte David <duartercorreia@hotmail.com>
@fcollonval fcollonval mentioned this pull request Dec 16, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@drcd1 drcd1

Labels
bug Something isn't working
Projects
None yet
Milestone
1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@drcd1 @fcollonval