Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for Stream class #484

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Update documentation for Stream class #484

merged 2 commits into from
Dec 5, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Dec 4, 2022

No description provided.

@afshin afshin added the documentation Improvements or additions to documentation label Dec 4, 2022
@afshin afshin added this to the Lumino 2 milestone Dec 4, 2022
@afshin afshin self-assigned this Dec 4, 2022
blink1073
blink1073 approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fcollonval
fcollonval approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afshin

@fcollonval fcollonval merged commit f1f6d98 into jupyterlab:main Dec 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees

@afshin afshin

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.
3 participants
@afshin @blink1073 @fcollonval