Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IDragEvent deprecated tag #561

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Remove IDragEvent deprecated tag #561

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40702fd
Remove IDrageEvent deprecated tag
afshin Mar 20, 2023
8bc9591
Keep the comment without the deprecated tag
afshin Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/dragdrop/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ export type SupportedActions =
* events, a drop target must cancel the `'lm-dragenter'` event by
* calling the event's `preventDefault()` method.
*
* @deprecated This interface will be deprecated in @lumino/dragdrop@^2.0.0 in favor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the comment even if there is no tag to properly highlight it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point. As long as it doesn't create a behavior in an IDE that looks out for the @deprecated tag, the information itself doesn't hurt.

* of ``Drag.Event``.
*/
export interface IDragEvent extends MouseEvent {
/**
Expand Down