added tabindex to tabbar #581
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
| @@ -1830,7 +1830,8 @@ namespace Private { | |||
| let node = document.createElement('div'); | |||
| let content = document.createElement('ul'); | |||
| content.setAttribute('role', 'tablist'); | |||
| content.className = 'lm-TabBar-content'; | |||
| content.setAttribute('tabindex', '0'); | |||
| content.className = 'lm-TabBar-content-test'; | |||
There was a problem hiding this comment.
Please restore the previous class.
| @@ -1830,7 +1830,8 @@ namespace Private { | |||
| let node = document.createElement('div'); | |||
| let content = document.createElement('ul'); | |||
| content.setAttribute('role', 'tablist'); | |||
| content.className = 'lm-TabBar-content'; | |||
| content.setAttribute('tabindex', '0'); | |||
There was a problem hiding this comment.
Please provide a rationale for setting the tabindex in the PR description explaining why it is needed and linking any relevant issues (in this or other repositories).
There was a problem hiding this comment.
Please undo all the changes to yarn.lock file. If you wish to upgrade any dependencies please do this in a separate dedicated PR unless the PR requires it (this one does not as far as I can see).
No description provided.