Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed tests for datagrid, test TextRenderer/drawText #585

Merged
merged 3 commits into from
May 17, 2023
Merged

Seed tests for datagrid, test TextRenderer/drawText #585

merged 3 commits into from
May 17, 2023

Conversation

krassowski
Copy link
Member

Follow-up to #578, first step towards #328 - this is not much but having the test scaffold should make it easier to add tests as we go.

@krassowski krassowski added the maintenance Dependencies, build, technical debt, etc. label May 11, 2023
@krassowski krassowski requested a review from afshin May 11, 2023 23:07
@krassowski krassowski mentioned this pull request May 12, 2023
Merged
afshin
afshin approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @krassowski!

@krassowski krassowski merged commit f904a6b into jupyterlab:main May 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees

@krassowski krassowski

Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krassowski @afshin