-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dev dependencies #599
Upgrade dev dependencies #599
Conversation
748dc84
to
87be071
Compare
I think it is safe to bump TypeScript from 4.9 t 5.1. But as we had issue before while bumping TypeScript, I would appreciate thoughts from other devs. cc @jupyterlab/jupyterlab-council |
I guess yarn and lerna deserve a bunch of attention also. My feedbacks
|
This PR may be relevant for the TypeScript 5.1 update: jupyterlab/jupyterlab#14638 |
👍 CI is greener (failing test are due to flakiness)
@echarles would you mind giving more details about your thinking here? I don't see the reasons for dev deps alignement between Lab and Lumino (it has almost never been true in the past). FYI I computed the diff for the types of diff --color packages/widgets/types/index.d.ts packages/widgets/types.bak/index.d.ts
0a1,4
> /**
> * @packageDocumentation
> * @module widgets
> */
Only in packages/widgets/types.bak: tsdoc-metadata.json The only change is the documentation addition by this PR. So it seems we will avoid the trouble hit in the past. |
I sometimes had to develop in both lumino and jupyterlab source base (one depending on the other). That's fine if it is not the case, it will just make life a bit harder some days. |
Bump: