-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expansion toggled signal of subpanels in an Accordion Panel #614
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DenisaCG
I have some cosmetic comments and a last minute thought that we could provide the index of the widget for which expansion changed to make the signal more powerful.
Thanks for the review @fcollonval! I applied the suggested cosmetic changes and added the index of the widget for the signal to provide. |
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fbde64d
to
2d56a0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DenisaCG
This is great.
I push a commit only to fix brackets in the test file that were not separating correctly the unit tests.
The remaining API failure is relevant and due to the extraction of the public API. To solve it, the command
|
Oh okay, that makes sense. Thank you @fcollonval! |
Added an
expansionToggled
signal to theAccordionPanel
class that gets triggered when an element from theAccordionPanel
is collapsed or expanded.The signal makes it useful for saving the layout of the sidebars, including the expansion status of all subpanels, such that once the user collapses a subpanel for example, the layout saves that information for later restoration.