Added role of button to addButton to make itkeyboard accessible when using screenreader #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fcollonval
added
bug
fcollonval
force-pushed
the
making-launcher-button-keyboard-accessible-with-screenreader
branch
from
3b4fb4b
to
282c88b
Compare
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: 14814
jupyterlab/jupyterlab#14814
In order to make the the addLauncher button keyboard accessible when using screen reader, added the role of button to the div element.
Tested using windows narrator. The add button is now keyboard accessible with screen reader and without it. In order to launch new launcher via keyboard: use Enter key or Spacebar Key.