Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom context menu for notebook tab #623

Closed

Conversation

s596757
Copy link
Contributor

@s596757 s596757 commented Aug 21, 2023

Updated code in order to allow the usage of menu button in order to open up custom context menu when on the notebook tab:

How to replicate:

  • open a new notebook
  • Tab until in notebook
  • press esc to get out of typing in notebook
  • press down arrow
  • press tab and you should be on notebook tab, press menu button and this open up the custom context menu via keyboard.

@fcollonval fcollonval added the bug Something isn't working label Sep 8, 2023
@fcollonval
Copy link
Member

Hey @s596757 would you mind providing more context on what this tries to fix. I tried you scenario in the current main branch on JupyterLab and everything works already:

context_menu

@m158261
Copy link
Contributor

m158261 commented Dec 6, 2023

Hey @fcollonval, this PR can be closed. It looks like this was a non issue. Thanks in advance.

@fcollonval fcollonval closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants