Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release Scripts #690

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Update Release Scripts #690

merged 2 commits into from
Mar 13, 2024

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 added the maintenance Dependencies, build, technical debt, etc. label Mar 12, 2024
@blink1073 blink1073 requested a review from jtpio March 12, 2024 16:50
jtpio
jtpio approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 909f600 into main Mar 13, 2024
16 of 17 checks passed
@krassowski
Copy link
Member

Can we delete this branch?

I noticed that I cannot remove it as it is protected along some other branches which I think should not be protected (see https://github.com/jupyterlab/lumino/rules/512358?ref=refs%2Fheads%2Fupdate-release-scripts)

@blink1073 blink1073 deleted the update-release-scripts branch March 21, 2024 11:07
@blink1073
Copy link
Contributor Author

I deleted it and adjusted the protection rules

@krassowski krassowski mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@blink1073 blink1073

Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @krassowski @jtpio