-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "chore(build): Bump Typescript to 3.9.2" #84
Conversation
- fixes jupyterlab#83 This reverts commit 36debf6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll merge and release in the morning |
I believe this all stems from a breaking change in the TypeScript language specification for unions and intersections - specifically this one: https://github.com/microsoft/TypeScript/wiki/Breaking-Changes#stricter-checks-on-intersections-and-optional-properties I haven't looked at what broke in the dependent code - but it may be a matter of adding FWIW some of the base types in the Lumino messaging library are simply wrong with the latest compiler (they end up evaluating to @telamonian - can I suggest you add some new unit tests which replicate the issues you hit and I can take a another look to see if there is a more "flexible" fix? |
@GordonSmith I am going to release a patch with this fix to unstick the majority of folks and then we can find a new path forward. |
For now you can pin to the exact version that has TS 3.9. |
Here are the transitions:
|
published |
JSONObject
in coreutils@1.5.1 are breaking jupyterlab extension builds #83This reverts commit 36debf6.