Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(build): Bump Typescript to 3.9.2" #84

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

telamonian
Copy link
Member

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Contributor

I'll merge and release in the morning

@blink1073 blink1073 merged commit e434a85 into jupyterlab:master Jun 26, 2020
@GordonSmith
Copy link
Contributor

GordonSmith commented Jun 26, 2020

I believe this all stems from a breaking change in the TypeScript language specification for unions and intersections - specifically this one: https://github.com/microsoft/TypeScript/wiki/Breaking-Changes#stricter-checks-on-intersections-and-optional-properties

I haven't looked at what broke in the dependent code - but it may be a matter of adding Partial<xxx> wrapper around the message type?

FWIW some of the base types in the Lumino messaging library are simply wrong with the latest compiler (they end up evaluating to {}).

@telamonian - can I suggest you add some new unit tests which replicate the issues you hit and I can take a another look to see if there is a more "flexible" fix?

@blink1073
Copy link
Contributor

@GordonSmith I am going to release a patch with this fix to unstick the majority of folks and then we can find a new path forward.

@blink1073
Copy link
Contributor

For now you can pin to the exact version that has TS 3.9.

@blink1073
Copy link
Contributor

Here are the transitions:

  • @lumino/example-datagrid: 0.6.0 => 0.6.1 (private)
  • @lumino/example-datastore: 0.3.1 => 0.3.2 (private)
  • @lumino/example-dockpanel: 0.3.1 => 0.3.2 (private)
  • @lumino/algorithm: 1.3.1 => 1.3.2
  • @lumino/application: 1.10.1 => 1.10.2
  • @lumino/collections: 1.3.1 => 1.3.2
  • @lumino/commands: 1.11.1 => 1.11.2
  • @lumino/coreutils: 1.5.1 => 1.5.2
  • @lumino/datagrid: 0.9.0 => 0.9.1
  • @lumino/datastore: 0.10.1 => 0.10.2
  • @lumino/default-theme: 0.4.1 => 0.4.2
  • @lumino/disposable: 1.4.1 => 1.4.2
  • @lumino/domutils: 1.2.1 => 1.2.2
  • @lumino/dragdrop: 1.6.1 => 1.6.2
  • @lumino/keyboard: 1.2.1 => 1.2.2
  • @lumino/messaging: 1.4.1 => 1.4.2
  • @lumino/polling: 1.3.1 => 1.3.2
  • @lumino/properties: 1.2.1 => 1.2.2
  • @lumino/signaling: 1.4.1 => 1.4.2
  • @lumino/virtualdom: 1.7.1 => 1.7.2
  • @lumino/widgets: 1.13.1 => 1.13.2

@blink1073
Copy link
Contributor

published

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Critical Bug] Changes to JSONObject in coreutils@1.5.1 are breaking jupyterlab extension builds
3 participants