Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates default minimum node version from 16 to 18 #174

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Updates default minimum node version from 16 to 18 #174

merged 1 commit into from
Jan 13, 2023

Conversation

JasonWeill
Copy link
Contributor

Related to jupyterlab/jupyterlab#13722 (issue jupyterlab/jupyterlab#13720), updates the default NodeJS version from 16.x to 18.x.

@welcome
Copy link

welcome bot commented Jan 6, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

blink1073
blink1073 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jtpio jtpio mentioned this pull request Jan 12, 2023
Merged
@jtpio
Copy link
Member

jtpio commented Jan 13, 2023

Thanks @JasonWeill!

Do you think this PR can be marked as ready?

@JasonWeill JasonWeill marked this pull request as ready for review January 13, 2023 17:04
@JasonWeill
Copy link
Contributor Author

We discussed Node 18 at this past week's JupyterLab meeting and I didn't hear any objections to the upgrade, so let's try it for real.

@blink1073
Copy link
Contributor

Cool, thanks! I'll publish this early next week, I don't like to make releases on a Friday. 😄

@blink1073 blink1073 merged commit 8478a3a into main Jan 13, 2023
@blink1073 blink1073 deleted the JasonWeill-patch-1 branch January 13, 2023 23:16
@welcome
Copy link

welcome bot commented Jan 13, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@JasonWeill
Copy link
Contributor Author

You don't like to make releases on Friday the 13th, @blink1073 ? 😄

Thanks for the merge — have a good weekend!

@blink1073
Copy link
Contributor

image

You too!

@fcollonval fcollonval mentioned this pull request Jan 16, 2023
Closed
@brichet brichet mentioned this pull request Jan 16, 2023
Merged
@andrii-i andrii-i mentioned this pull request Jan 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonWeill @jtpio @blink1073