Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore JS tests #33

Merged
merged 3 commits into from
Mar 14, 2021
Merged

Conversation

fcollonval
Copy link
Member

Restore existing JS tests

@codecov-io
Copy link

Codecov Report

Merging #33 (7c939ee) into master (c081dbd) will decrease coverage by 30.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
- Coverage   89.85%   58.93%   -30.92%     
===========================================
  Files          13       31       +18     
  Lines         936     1629      +693     
  Branches        0       92       +92     
===========================================
+ Hits          841      960      +119     
- Misses         95      664      +569     
- Partials        0        5        +5     
Impacted Files Coverage Δ
src/tokens.ts 100.00% <ø> (ø)
src/components/browser/PullRequestItem.tsx 48.07% <100.00%> (ø)
src/components/discussion/Discussion.ts 60.91% <100.00%> (ø)
src/components/browser/Browser.tsx 100.00% <0.00%> (ø)
src/components/Toolbar.tsx 0.00% <0.00%> (ø)
src/style/icons.ts 0.00% <0.00%> (ø)
src/components/diff/plaintext.ts 0.00% <0.00%> (ø)
src/components/tab/DescriptionWidget.ts 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c081dbd...7c939ee. Read the comment docs.

@fcollonval fcollonval marked this pull request as ready for review March 13, 2021 17:17
- name: Unit Test JS (known to be broken)
run: jlpm test || echo "TODO"
- name: Unit Test JS
run: jlpm test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -39,7 +39,7 @@
"clean:labextension": "rimraf jupyterlab_pullrequests/labextension",
"eslint": "eslint . --ext .ts,.tsx --fix",
"eslint:check": "eslint . --ext .ts,.tsx",
"test": "jest",
"test": "jest --coverage",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤤

Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge at your leisure, if you've nothing else planned.

@fcollonval fcollonval merged commit 916a3ea into jupyterlab:master Mar 14, 2021
@fcollonval fcollonval deleted the fcollonval/issue31 branch March 14, 2021 12:54
@bollwyvl
Copy link
Contributor

Will update my sub-pr to get this proper for lab 3.

@fcollonval
Copy link
Member Author

Thanks

@bollwyvl bollwyvl mentioned this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants