-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore JS tests #33
Restore JS tests #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
===========================================
- Coverage 89.85% 58.93% -30.92%
===========================================
Files 13 31 +18
Lines 936 1629 +693
Branches 0 92 +92
===========================================
+ Hits 841 960 +119
- Misses 95 664 +569
- Partials 0 5 +5
Continue to review full report at Codecov.
|
- name: Unit Test JS (known to be broken) | ||
run: jlpm test || echo "TODO" | ||
- name: Unit Test JS | ||
run: jlpm test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -39,7 +39,7 @@ | |||
"clean:labextension": "rimraf jupyterlab_pullrequests/labextension", | |||
"eslint": "eslint . --ext .ts,.tsx --fix", | |||
"eslint:check": "eslint . --ext .ts,.tsx", | |||
"test": "jest", | |||
"test": "jest --coverage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge at your leisure, if you've nothing else planned.
Will update my sub-pr to get this proper for lab 3. |
Thanks |
Restore existing JS tests