Handle user overrides

jupyterlab · Nov 29, 2021 · fe7a67d · fe7a67d
1 parent 23662b2
commit fe7a67d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/application-extension/src/index.ts b/packages/application-extension/src/index.ts
@@ -527,14 +527,14 @@ const topVisibility: JupyterFrontEndPlugin<void> = {
       menu.viewMenu.addGroup([{ command: CommandIDs.toggleTop }], 2);
     }
 
-    let settingOverride = false;
+    let settingsOverride = false;
 
     if (settingRegistry) {
       const loadSettings = settingRegistry.load(pluginId);
       const updateSettings = (settings: ISettingRegistry.ISettings): void => {
         const visible = settings.get('visible').composite;
-        if (visible !== undefined) {
-          settingOverride = true;
+        if (settings.user.visible !== undefined) {
+          settingsOverride = true;
           top.setHidden(!visible);
         }
       };
@@ -552,7 +552,7 @@ const topVisibility: JupyterFrontEndPlugin<void> = {
     }
 
     const onChanged = (): void => {
-      if (settingOverride) {
+      if (settingsOverride) {
         return;
       }
       if (app.format === 'desktop') {