Exiting terminal doesn't close window tab

[davidbrochart]

Problem

When exiting a terminal by entering exit, it would be nice for the window tab to close as well.
Currently, the user is left with an empty page:

Proposed Solution

Maybe use:

window.close();

Additional context

That would match JupyterLab's behavior (for which the tab is closed).

[jtpio]

Thanks @davidbrochart.

Maybe use:

window.close();

Right there could be small plugin in the terminal-extension package that listens to widget.disposed and performs this action.

For reference the classic notebook keeps the terminal widget displayed, and appends [CLOSED]:

classic-terminal-closed.mp4

[jtpio]

Thinking about this more, I'm wondering if automatically closing the tab might be a bit too aggressive.

For example we could imagine someone running something in the terminal, and expecting to keep the output of a command displayed on the screen. Ideally we would find a way to replicate the behavior of the classic notebook and keep the terminal widget displayed on the page after exit. Although it's true that in JupyterLab the terminal widget is just disposed.

[davidbrochart]

Yes, I agree that we should try and keep as close as possible to the classic notebook.