Update to JupyterLab 4.0 alpha

[jtpio]

Fixes #303
Fixes #299

To start checking for breaking changes, and the new packages / plugins to add to the build.

• Update the @jupyterlab packages to next
• Update the @lumino packages to latest
• Fix plugins failing to activate
• Fix notebook toolbar items not displayed

Keeping as a draft for now.

[github-actions]

👈 Launch a Binder on branch jtpio/retrolab/lab-4

[jtpio]

cc @davidbrochart the build seems to be passing on CI

[davidbrochart]

I tried pip install -e . with this branch and got:

    lerna ERR! yarn run build exited 1 in '@retrolab/lab-extension'
    lerna ERR! yarn run build stdout:
    $ jlpm run build:lib && jlpm run build:labextension:dev
    $ tsc
    src/index.ts(67,5): error TS2322: Type 'Token<IRetroShell>' is not assignable to type 'Token<any>'.
      Types have separate declarations of a private property '_tokenStructuralPropertyT'.

[jtpio]

Strange. This seems to be building fine locally and also on Binder, which installs from source as follows:

retrolab/binder/postBuild

Lines 1 to 8 in da09750

	#!/bin/bash
	set -euo pipefail
	python -m pip install -e .
	jlpm && jlpm run build
	jlpm run develop
	jupyter server extension enable retrolab
	jupyter serverextension enable retrolab

[jtpio]

There is now a 0.3.x branch created from the 0.3.16 release commit: https://github.com/jupyterlab/retrolab/tree/0.3.x

So we can move forward with this PR and start targeting JupyterLab 4 on main.

[jtpio]

Still left to do: show the notebook toolbar items, which might be related to this upstream PR: jupyterlab/jupyterlab#10469

[davidbrochart]

I was trying to set the option to not close terminals on exit, but adding terminal.content.setOption("closeOnExit", false); somewhere here doesn't seem to work. Any idea?

[jtpio]

@davidbrochart I wonder if this should be set here instead:

retrolab/packages/terminal-extension/src/index.ts

Line 40 in 3470287

commands.execute('terminal:open', { name });

iirc the other plugin handles opening in a new browser tab.

[jtpio]

Still left to do: show the notebook toolbar items, which might be related to this upstream PR: jupyterlab/jupyterlab#10469

This one looks like a race condition. Adding an artificial delay such as following seems lets the toolbar be correctly populated:

diff --git a/packages/application-extension/src/index.ts b/packages/application-extension/src/index.ts
index 109fd19..866570b 100644
--- a/packages/application-extension/src/index.ts
+++ b/packages/application-extension/src/index.ts
@@ -181,9 +181,11 @@ const opener: JupyterFrontEndPlugin<void> = {
         app.restored.then(() => {
           // TODO: get factory from file type instead?
           if (ext === '.ipynb') {
-            docManager.open(file, NOTEBOOK_FACTORY, undefined, {
-              ref: '_noref'
-            });
+            setTimeout(() => {
+              docManager.open(file, NOTEBOOK_FACTORY, undefined, {
+                ref: '_noref'
+              });
+            }, 1000);
           } else {
             docManager.open(file, EDITOR_FACTORY, undefined, {
               ref: '_noref'

toolbar-notebook-delay.mp4

[davidbrochart]

Thanks, that was it!
I opened jtpio#4.

[jtpio]

Nice thanks @davidbrochart!

[jtpio]

Adding an artificial delay such as following seems lets the toolbar be correctly populated

cc @fcollonval who might know if this is related to the logic in jupyterlab/jupyterlab#10469

[jtpio]

Using the following trick like in the toolbar.spec.ts upstream tests seems to do it:

https://github.com/jupyterlab/jupyterlab/blob/50fa0047d63287005a2c3b1d8f5bfedfe56cde7e/packages/apputils/test/toolbar.spec.ts#L304-L308

await settingRegistry?.load('@jupyterlab/notebook-extension:panel');
await Promise.resolve();

[jtpio]

This is what the user menu dropdown looks like in RetroLab when RTC is enabled:

[jtpio]

We should investigate if it is possible to fix this upstream as this is very brittle.

[fcollonval]

A toolbar definition may indeed not be fully known by the time the open is triggered as some plugins may not yet be loaded or the treatment of the settings may not be complete yet. Hence adding some sort of delay does the trick.

[jtpio]

Merging that one since CI is now green.

Will make a 0.4.0a0 prerelease with this right after.

[jtpio]

0.4.0a0 is out: https://github.com/jupyterlab/retrolab/releases/tag/v0.4.0a0