-
-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
@jtpio unsure what's going on but this is still not working. I'll get back it sometime after the holiday week (in the states). |
Test dockerfile and image: https://github.com/jabbera/retrolab/blob/hub_docker/Dockerfile jabberaa/retro:latest |
Couldn't stay away. hub-extension looks for a setting called hubPrefix in the paths that comes from the page config I had to bring over these lines from JupyterLab to set the property I'm unsure about resetting the token and this PR should be reviewed carefully but the menu item shows up and works. |
Thanks @jabbera for investigating this 👍
Maybe we'll also need to bring this logic to |
I brought them over in this PR and it sorted the issue. |
Great, thanks @jabbera.
EDIT: done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 0.2.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
[0.2.x] Backport #148 (Enable hub-extension)
Add the
@jupyterlab-hub-extension
to show the "Hub Control Panel" and "Log Out" menu entries when running RetroLab in JupyterHub: