Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Enable hub-extension #148

Merged
merged 3 commits into from
May 31, 2021
Merged

Enable hub-extension #148

merged 3 commits into from
May 31, 2021

Conversation

jabbera
Copy link

@jabbera jabbera commented May 28, 2021

Add the @jupyterlab-hub-extension to show the "Hub Control Panel" and "Log Out" menu entries when running RetroLab in JupyterHub:

image

@welcome
Copy link

welcome bot commented May 28, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch RetroLab on Binder

@jabbera jabbera changed the title Enable hub-extension DRAFT: Enable hub-extension May 28, 2021
@jabbera jabbera changed the title DRAFT: Enable hub-extension Enable hub-extension May 28, 2021
@jabbera jabbera changed the title Enable hub-extension Draft: Enable hub-extension May 28, 2021
@jabbera
Copy link
Author

jabbera commented May 28, 2021

@jtpio unsure what's going on but this is still not working. I'll get back it sometime after the holiday week (in the states).

@jabbera
Copy link
Author

jabbera commented May 28, 2021

Test dockerfile and image:

https://github.com/jabbera/retrolab/blob/hub_docker/Dockerfile

jabberaa/retro:latest

@jabbera
Copy link
Author

jabbera commented May 29, 2021

Couldn't stay away.

hub-extension looks for a setting called hubPrefix in the paths that comes from the page config

I had to bring over these lines from JupyterLab to set the property

I'm unsure about resetting the token and this PR should be reviewed carefully but the menu item shows up and works.

@jabbera jabbera changed the title Draft: Enable hub-extension Enable hub-extension May 29, 2021
@jtpio
Copy link
Member

jtpio commented May 30, 2021

Thanks @jabbera for investigating this 👍

I had to bring over these lines from JupyterLab to set the property

Maybe we'll also need to bring this logic to retrolab for now. Or maybe find a way to make it more reusable across lab-based applications.

@jabbera
Copy link
Author

jabbera commented May 30, 2021

I brought them over in this PR and it sorted the issue.

@jtpio
Copy link
Member

jtpio commented May 30, 2021

Great, thanks @jabbera.

Would you mind posting a quick screenshot in the top comment for reference? Thanks!

EDIT: done

@jtpio jtpio added this to the 0.3.0 milestone May 30, 2021
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0f7c026 into jupyterlab:main May 31, 2021
@welcome
Copy link

welcome bot commented May 31, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jtpio
Copy link
Member

jtpio commented May 31, 2021

@meeseeksdev please backport to 0.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 31, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 0.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 0f7c026472e64b9f9073cce47a00c072d6a84af5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #148: Enable hub-extension'
  1. Push to a named branch :
git push YOURFORK 0.2.x:auto-backport-of-pr-148-on-0.2.x
  1. Create a PR against branch 0.2.x, I would have named this PR:

"Backport PR #148 on branch 0.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jtpio pushed a commit to jtpio/retrolab that referenced this pull request May 31, 2021
jtpio pushed a commit to jtpio/retrolab that referenced this pull request May 31, 2021
jtpio added a commit that referenced this pull request May 31, 2021
[0.2.x] Backport #148 (Enable hub-extension)
@jabbera jabbera deleted the hub_extension branch May 31, 2021 13:37
@jtpio jtpio mentioned this pull request Aug 26, 2021