Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Ensure @retrolab settings #265

Merged
merged 9 commits into from
Nov 1, 2021
Merged

Ensure @retrolab settings #265

merged 9 commits into from
Nov 1, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 31, 2021

Fixes #4

  • Copy the @retrolab schemas to PREFIX/share/jupyter/lab/schemas so the retro settings can be persisted, and modified via the advanced settings editor in JupyterLab
  • Improve handling of schemas with editable installs

This might also help with jupyter/notebook#6398, jupyter/notebook#6409 and jupyter/notebook#6408

@jtpio jtpio added the enhancement New feature or request label Oct 31, 2021
@jtpio jtpio added this to the 0.3.x milestone Oct 31, 2021
@github-actions
Copy link
Contributor

Binder 👈 Launch RetroLab on Binder

@jtpio
Copy link
Member Author

jtpio commented Nov 1, 2021

Looking good on Binder, with the "Show Header" toggle being persisted after a page reload:

persist-retro-settings.mp4

@jtpio jtpio marked this pull request as ready for review November 1, 2021 17:16
@jtpio
Copy link
Member Author

jtpio commented Nov 1, 2021

This should also be useful if we want to set custom keyboard shortcuts for retro only.

@jtpio jtpio merged commit 45f879d into jupyterlab:main Nov 1, 2021
@jtpio jtpio deleted the settings branch November 1, 2021 18:19
@jtpio jtpio mentioned this pull request Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure schemas exist for @retrolab plugins
1 participant