Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Fix plugin ids in the notebook extension #284

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fix plugin ids in the notebook extension #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions packages/notebook-extension/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { NotebookPanel } from '@jupyterlab/notebook';

import { ITranslator } from '@jupyterlab/translation';

import { RetroApp, IRetroShell } from '@retrolab/application';
import { IRetroShell } from '@retrolab/application';

import { Poll } from '@lumino/polling';

Expand Down Expand Up @@ -46,7 +46,7 @@ const KERNEL_STATUS_FADE_OUT_CLASS = 'jp-RetroKernelStatus-fade';
* A plugin for the checkpoint indicator
*/
const checkpoints: JupyterFrontEndPlugin<void> = {
id: '@retrolab/application-extension:checkpoints',
id: '@retrolab/notebook-extension:checkpoints',
autoStart: true,
requires: [IDocumentManager, ITranslator],
optional: [IRetroShell],
Expand Down Expand Up @@ -104,7 +104,7 @@ const checkpoints: JupyterFrontEndPlugin<void> = {
* The kernel logo plugin.
*/
const kernelLogo: JupyterFrontEndPlugin<void> = {
id: '@retrolab/application-extension:kernel-logo',
id: '@retrolab/notebook-extension:kernel-logo',
autoStart: true,
requires: [IRetroShell],
activate: (app: JupyterFrontEnd, shell: IRetroShell) => {
Expand Down Expand Up @@ -156,7 +156,7 @@ const kernelLogo: JupyterFrontEndPlugin<void> = {
* A plugin to display the kernel status;
*/
const kernelStatus: JupyterFrontEndPlugin<void> = {
id: '@retrolab/application-extension:kernel-status',
id: '@retrolab/notebook-extension:kernel-status',
autoStart: true,
requires: [IRetroShell],
activate: (app: JupyterFrontEnd, shell: IRetroShell) => {
Expand Down Expand Up @@ -209,21 +209,6 @@ const kernelStatus: JupyterFrontEndPlugin<void> = {
}
};

/**
* The default paths for a RetroLab app.
*/
const paths: JupyterFrontEndPlugin<JupyterFrontEnd.IPaths> = {
id: '@retrolab/application-extension:paths',
activate: (app: JupyterFrontEnd): JupyterFrontEnd.IPaths => {
if (!(app instanceof RetroApp)) {
throw new Error(`${paths.id} must be activated in RetroLab.`);
}
return app.paths;
},
autoStart: true,
provides: JupyterFrontEnd.IPaths
};

/**
* Export the plugins as default.
*/
Expand Down