Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jupyter-server-ydoc in this organization #175

Closed
fcollonval opened this issue Jan 26, 2023 · 5 comments
Closed

Move jupyter-server-ydoc in this organization #175

fcollonval opened this issue Jan 26, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@fcollonval
Copy link
Member

fcollonval commented Jan 26, 2023

Problem

A target for 4.0.0 is to extract collaboration feature of JupyterLab core (jupyterlab/jupyterlab#13726).

The rational behind it:

  • RTC final implementation breaks lots of hypothesis on content management by the server
    • Needs to use a file IDs service to track file (which can be incompatible with custom ContentsManager)
    • File content and deltas are served by a server extension connected to clients by websockets - the content REST API is not longer used (especially save are not triggered by the client but by the server extension).
    • Introducing a server extension makes it harder to implement pure front-end alternative for JupyterLite (using webRTC)
  • Collaboration stays optional and avoid installing unneeded server extensions.

The remaining question is where to place the extracted code.

Proposed Solution

The logic seems to move the code in a repository within this organization as it comes from core JupyterLab and it is officially supported by the JupyterLab development team. But as it interacts directly with an existing server extension, I'ld like to propose moving the code in that server extension repository (to avoid repository explosion) and to move that repository from jupyter-server to jupyterlab organization.

@fcollonval fcollonval added the enhancement New feature or request label Jan 26, 2023
@fcollonval
Copy link
Member Author

cc @jupyterlab/jupyterlab-council what do you think?

@ellisonbg
Copy link
Contributor

ellisonbg commented Jan 26, 2023 via email

@jtpio
Copy link
Member

jtpio commented Jan 27, 2023

Moving the repo to the jupyterlab organization sounds good.

@fcollonval
Copy link
Member Author

A consensus to move the repository in jupyterlab organization was reached during the weekly meeting.

A separate discussion about that package being shipped by default with JupyterLab 4.0.0 is happening there

@afshin
Copy link
Member

afshin commented Feb 3, 2023

The repository is now in the jupyterlab org:

https://github.com/jupyterlab/jupyter_server_ydoc

@afshin afshin closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants