Prebuild worker bundle and import WASM files from same directory as JS wrappers #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes required to ensure the latest code here works in the JupyterLite terminal. Changes are:
locateFileto load WASM files from the same directory as their JS wrapper files.rspack(webpackwould also work).Whilst doing item 1 I have also chosen to make the
wasmBaseUrloption compulsory, as all existing uses set it anyway.Item 2 is a temporary fix so that the WebWorker works OK in a JupyterLite deployment. It should, and eventually will, be in the terminal extension instead.
After this is merged I will release version 0.0.8 and make the corresponding changes in the terminal extension.