Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the path convention of other directives like literalinclude #54

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jasongrout
Copy link
Collaborator

@jasongrout jasongrout commented Jun 16, 2022

We adopt the conventions of the sphinx literalinclude directive using similar logic:

  • If the path is absolute, it is considered as relative to the document root (after stripping off the initial /)
  • If the path is relative, it is considered as relative to the source document

- If the path is absolute, it is considered as relative to the document root (after stripping off the initial /)
- If the path is relative, it is considered as relative to the source document
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@martinRenou martinRenou merged commit 0e8f3c0 into jupyterlite:main Jun 17, 2022
@jtpio jtpio added the enhancement New feature or request label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants