Split package in two: extension and library #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
restructure
branch
3 times, most recently
from
1d8b7c2 to
9aa098f
Compare
trungleduc
approved these changes
Dec 13, 2024
|
@trungleduc thanks for the review! I will merge your PR first then resolve conflicts |
martinRenou
force-pushed
the
restructure
branch
from
5c7347d to
45cee29
Compare
jtpio
reviewed
Dec 13, 2024
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "name": "@jupyterlite/xeus", | |||
| "name": "@jupyterlite/xeus-root", | |||
There was a problem hiding this comment.
This change of name from @jupyterlite/xeus to @jupyterlite/xeus-extension for the extension should probably be documented somewhere, at least in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.