Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable block length in processBlock #2

Closed
Tracked by #1
jurihock opened this issue Dec 3, 2023 · 0 comments · Fixed by #4
Closed
Tracked by #1

Variable block length in processBlock #2

jurihock opened this issue Dec 3, 2023 · 0 comments · Fixed by #4
Labels
enhancement New feature or request
Milestone
v1

Comments

@jurihock
Copy link
Owner

jurihock commented Dec 3, 2023 •
edited
Loading

Observations:

  • Standalone app never changes the block size in processBlock.
  • Logic changes the block size once in the first processBlock callback.
  • Audacity permanently changes the block size in processBlock, e.g. between 512 and 157 (max. 1156).

One way to handle variable blocks would be to delay the output by the max. block size reported in prepareToPlay and report the resulting latency back by setting setLatencySamples. Therefore, two modes of operation need to be introduced, e.g. offline and online mode.
@jurihock jurihock mentioned this issue Dec 3, 2023
Open
9 tasks
@jurihock jurihock changed the title Explore the variable block length in processBlock (doesn't seem to be an issue in the standalone app) Variable block length in processBlock Dec 3, 2023
@jurihock jurihock added the enhancement New feature or request label Dec 3, 2023
jurihock added a commit that referenced this issue Dec 7, 2023
@jurihock
Add low latency mode #2
8647911
jurihock added a commit that referenced this issue Dec 8, 2023
@jurihock
Report effect delay #2
f31a28b
@jurihock jurihock linked a pull request Dec 10, 2023 that will close this issue
Handle variable block length in processBlock #2 #4
Merged
jurihock added a commit that referenced this issue Dec 10, 2023
@jurihock
Handle variable block length in processBlock #2 (#4)
200c5f3 
* Add low latency mode #2

* Update DelayedCore.cpp

* Report effect delay #2

* Fix DelayedCore

* Fix missing typecast

* Fix latency callback

* Fix span

* Fix latency callback

* Use symmetric window in delayed core

* Fix latency callback

* Update InstantCore.cpp

* Delete audacity plugin cache

* Update screenshot.png

* Update MANUAL.md

* Log latency

* Fix typecast
@jurihock jurihock added this to the v1 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

Handle variable block length in processBlock #2 jurihock/stftPitchShiftPlugin
1 participant
@jurihock