fix: threeDsMethod logs change

juspay · Apr 17, 2024 · 4a3f2be · 4a3f2be
1 parent 1ac46bf
commit 4a3f2be
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 30 deletions.
diff --git a/src/Payments/CardPayment.res b/src/Payments/CardPayment.res
@@ -190,8 +190,6 @@ let make = (
 
   let nicknameFieldClassName = conditionsForShowingSaveCardCheckbox ? "pt-2" : "pt-5"
 
-  Js.log2("sdvjnsddsjd", (list.mandate_payment, options.terms.card))
-
   <div className="animate-slowShow">
     <RenderIf condition={showFields || isBancontact}>
       <div

diff --git a/src/ThreeDSMethod.res b/src/ThreeDSMethod.res
@@ -12,7 +12,7 @@ let make = () => {
     LoggerUtils.handleLogging(
       ~optLogger=Some(logger),
       ~eventName=THREE_DS_METHOD_RESULT,
-      ~value="Successful Form Submission",
+      ~value="Y",
       ~paymentMethod="CARD",
       (),
     )
@@ -59,14 +59,13 @@ let make = () => {
 
         let iframeId = metaDataDict->getString("iframeId", "")
 
-        let handleFailureScenarios = (eventName, value, internalMetadata, logType) => {
+        let handleFailureScenarios = value => {
           LoggerUtils.handleLogging(
             ~optLogger=Some(logger),
-            ~eventName,
+            ~eventName=THREE_DS_METHOD_RESULT,
             ~value,
-            ~internalMetadata,
             ~paymentMethod="CARD",
-            ~logType,
+            ~logType=ERROR,
             (),
           )
           metadata->Utils.getDictFromJson->Dict.set("3dsMethodComp", "N"->JSON.Encode.string)
@@ -89,31 +88,16 @@ let make = () => {
             input.value = encodeURIComponent(threeDsMethodStr)
             form.target = "threeDsInvisibleIframe"
             form.appendChild(input)
-
-            LoggerUtils.handleLogging(
-              ~optLogger=Some(logger),
-              ~eventName=THREE_DS_METHOD,
-              ~value="Submitting Form",
-              ~paymentMethod="CARD",
-              (),
-            )
-
             try {
               form.submit()
             } catch {
             | err => {
                 let exceptionMessage = err->Utils.formatException->JSON.stringify
-                handleFailureScenarios(
-                  THREE_DS_METHOD_RESULT,
-                  "Form Submission Failed",
-                  exceptionMessage,
-                  ERROR,
-                )
+                handleFailureScenarios(exceptionMessage)
               }
             }
           }
-        | None =>
-          handleFailureScenarios(THREE_DS_METHOD, "Unable to Locate threeDsInvisibleDiv", "", INFO)
+        | None => handleFailureScenarios("Unable to Locate threeDsInvisibleDiv")
         }
       }
     }

diff --git a/src/orca-log-catcher/OrcaLogger.res b/src/orca-log-catcher/OrcaLogger.res
@@ -14,8 +14,6 @@ type eventName =
   | RETRIEVE_CALL
   | AUTHENTICATION_CALL_INIT
   | AUTHENTICATION_CALL
-  | THREE_DS_METHOD_CALL_INIT
-  | THREE_DS_METHOD_CALL
   | CONFIRM_CALL_INIT
   | CONFIRM_CALL
   | SESSIONS_CALL_INIT
@@ -79,8 +77,6 @@ let eventNameToStrMapper = eventName => {
   | RETRIEVE_CALL => "RETRIEVE_CALL"
   | AUTHENTICATION_CALL_INIT => "AUTHENTICATION_CALL_INIT"
   | AUTHENTICATION_CALL => "AUTHENTICATION_CALL"
-  | THREE_DS_METHOD_CALL_INIT => "THREE_DS_METHOD_CALL_INIT"
-  | THREE_DS_METHOD_CALL => "THREE_DS_METHOD_CALL"
   | CONFIRM_CALL_INIT => "CONFIRM_CALL_INIT"
   | CONFIRM_CALL => "CONFIRM_CALL"
   | SESSIONS_CALL_INIT => "SESSIONS_CALL_INIT"
@@ -499,7 +495,7 @@ let make = (
       PAYMENT_ATTEMPT,
       CONFIRM_CALL,
       AUTHENTICATION_CALL,
-      THREE_DS_METHOD_CALL,
+      THREE_DS_METHOD_RESULT,
       SDK_CRASH,
       REDIRECTING_USER,
       DISPLAY_BANK_TRANSFER_INFO_PAGE,
@@ -508,6 +504,7 @@ let make = (
       LOADER_CHANGED,
       SESSIONS_CALL,
       RETRIEVE_CALL,
+      DISPLAY_THREE_DS_SDK,
     ]
     arrayOfLogs
     ->Array.find(log => {
@@ -542,7 +539,6 @@ let make = (
         }
       }
     | AUTHENTICATION_CALL
-    | THREE_DS_METHOD_CALL
     | RETRIEVE_CALL
     | CONFIRM_CALL
     | SESSIONS_CALL