Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to handle confirm button (E2E) #198

Merged
merged 14 commits into from
Mar 11, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja commented Mar 5, 2024

Updated with this in themeObject -

{
  ...,
  buttonBackgroundColor: string,
  buttonHeight: string,
  buttonWidth: string,
  buttonBorderRadius: string,
  buttonBorderColor: string,
  buttonTextColor: string,
  buttonTextFontSize: string,
  buttonTextFontWeight: string,
}

and sdkHandleConfirmPayment will hold this

sdkHandleConfirmPayment:
     {
      handleConfirm: true,
      buttontext: string,
      confirmParams: {
        return_url: "http://localhost:9060/",
      },
   },

@PritishBudhiraja PritishBudhiraja linked an issue Mar 5, 2024 that may be closed by this pull request
@PritishBudhiraja PritishBudhiraja changed the title fix: Change sdk handle confirm payment positioning feat: Support to handle confirm button (E2E) Mar 5, 2024
@vsrivatsa-edinburgh vsrivatsa-edinburgh force-pushed the change-sdkHandleConfirmPayment-positiobn branch from f73c060 to f96f5f5 Compare March 5, 2024 16:51
src/Types/PaymentType.res Outdated Show resolved Hide resolved
src/Types/PaymentType.res Outdated Show resolved Hide resolved
src/Types/PaymentType.res Outdated Show resolved Hide resolved
src/BrutalTheme.res Outdated Show resolved Hide resolved
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey i think lot of lines will be reduced if you keep the customization in a single object
it also ease the process of customization and reduces confusion
DevX is enhanced

src/LoaderController.res Outdated Show resolved Hide resolved
src/Types/PaymentType.res Show resolved Hide resolved
@PritishBudhiraja
Copy link
Collaborator Author

Hey i think lot of lines will be reduced if you keep the customization in a single object it also ease the process of customization and reduces confusion DevX is enhanced

Updated @prafulkoppalkar . Please recheck the PR

@ArushKapoorJuspay ArushKapoorJuspay force-pushed the change-sdkHandleConfirmPayment-positiobn branch 4 times, most recently from 0d132a8 to 3eb2e2e Compare March 11, 2024 20:29
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine merging this

Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine merging this

@prafulkoppalkar prafulkoppalkar merged commit a4ffecf into main Mar 11, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the change-sdkHandleConfirmPayment-positiobn branch March 11, 2024 21:10
akash-c-k pushed a commit that referenced this pull request Mar 11, 2024
# [0.30.0](v0.29.1...v0.30.0) (2024-03-11)

### Features

* Support to handle confirm button (E2E) ([#198](#198)) ([a4ffecf](a4ffecf))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
# [0.30.0](juspay/hyperswitch-web@v0.29.1...v0.30.0) (2024-03-11)

### Features

* Support to handle confirm button (E2E) ([#198](juspay/hyperswitch-web#198)) ([a4ffecf](juspay/hyperswitch-web@a4ffecf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support to handle confirm button (E2E)
4 participants