-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add saved payment methods throughout checkout #254
Merged
prafulkoppalkar
merged 5 commits into
main
from
saved-payment-methods-throughout-checkout
Mar 26, 2024
Merged
fix: add saved payment methods throughout checkout #254
prafulkoppalkar
merged 5 commits into
main
from
saved-payment-methods-throughout-checkout
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
requested review from
prafulkoppalkar,
akash-c-k and
ArushKapoorJuspay
as code owners
March 26, 2024 05:55
prafulkoppalkar
previously approved these changes
Mar 26, 2024
vsrivatsa-edinburgh
previously approved these changes
Mar 26, 2024
prafulkoppalkar
previously approved these changes
Mar 26, 2024
PritishBudhiraja
dismissed stale reviews from vsrivatsa-edinburgh and prafulkoppalkar
via
March 26, 2024 09:49
78de50d
PritishBudhiraja
requested review from
ArushKapoorJuspay,
prafulkoppalkar and
vsrivatsa-edinburgh
March 26, 2024 09:52
ArushKapoorJuspay
approved these changes
Mar 26, 2024
prafulkoppalkar
approved these changes
Mar 26, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Mar 26, 2024
## [0.34.4](v0.34.3...v0.34.4) (2024-03-26) ### Bug Fixes * add saved payment methods throughout checkout ([#254](#254)) ([75be834](75be834))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
## [0.34.4](juspay/hyperswitch-web@v0.34.3...v0.34.4) (2024-03-26) ### Bug Fixes * add saved payment methods throughout checkout ([#254](juspay/hyperswitch-web#254)) ([75be834](juspay/hyperswitch-web@75be834))
ArushKapoorJuspay
pushed a commit
that referenced
this pull request
Sep 23, 2024
Merge in EXC/orca-elements from bugfix/append_child_script to master * commit '67e631e5c43e3e4c9024e0bce4012d9cb3472fe5': Window.onload appendChild on load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Saved Payment Methods screen was unable to navigate except via cards, but it should be accessible via all payment methods. I've relocated it from Card Payment to the Root component.
How did you test it?
Go to every Payment Methods screen and check the -
Use saved payment method
button should be there to navigate to the Saved Payment Methods Screen.Checklist
npm run re:build