feat(3ds): three DS SDK - adding logs to track milestone events #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsrivatsa-edinburgh
requested review from
prafulkoppalkar and
ArushKapoorJuspay
as code owners
src/ThreeDSMethod.res
Outdated
| @@ -40,33 +40,63 @@ let make = () => { | |||
| ->Belt.Option.flatMap(JSON.Decode.object) | |||
| ->Belt.Option.flatMap(x => x->Dict.get("three_ds_method_data")) | |||
| ->Option.getOr(Dict.make()->JSON.Encode.object) | |||
| let paymentIntentId = | |||
| metaDataDict | |||
| ->Dict.get("paymentIntentId") | |||
There was a problem hiding this comment.
getString function can be used I guess. Check once for both the values
added 3 commits
March 28, 2024 15:59
ArushKapoorJuspay
previously approved these changes
Mar 28, 2024
PritishBudhiraja
previously approved these changes
Mar 28, 2024
…ree_ds_iframe_logs
vsrivatsa-edinburgh
dismissed stale reviews from PritishBudhiraja and ArushKapoorJuspay
via
32fbfac
vsrivatsa-edinburgh
requested review from
ArushKapoorJuspay and
PritishBudhiraja
PritishBudhiraja
approved these changes
Apr 3, 2024
prafulkoppalkar
approved these changes
Apr 4, 2024
akash-c-k
approved these changes
Apr 4, 2024
akash-c-k
pushed a commit
that referenced
this pull request
Apr 4, 2024
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
# [0.36.0](juspay/hyperswitch-web@v0.35.6...v0.36.0) (2024-04-04) ### Features * **3ds:** three DS SDK - adding logs to track milestone events ([#265](juspay/hyperswitch-web#265)) ([ceab161](juspay/hyperswitch-web@ceab161)) * giropay dynamic fields added ([#267](juspay/hyperswitch-web#267)) ([ad2fa63](juspay/hyperswitch-web@ad2fa63))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Three DS SDK - adding logs to track milestone events
Motivation and Context
Three DS authentication analytics and audit trail tracking
How did you test it?
Check payment logs against a payment ID (with 3DS 2.0 flow)
Checklist
npm run re:build