Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: phone country dropdown added #270

Merged
merged 57 commits into from
May 10, 2024
Merged

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

need to add a drop down for all the phone country code values

How did you test it?

Rendered the phone number field and we can check the dropdown is visible with all country - phone number code values

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

prafulkoppalkar
prafulkoppalkar previously approved these changes Apr 4, 2024
@PritishBudhiraja PritishBudhiraja added the Added Comments - waiting for author Add this label when comments added in the PR and waiting for the author to get those resolved. label Apr 5, 2024
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. and removed Added Comments - waiting for author Add this label when comments added in the PR and waiting for the author to get those resolved. labels Apr 5, 2024
prafulkoppalkar
prafulkoppalkar previously approved these changes May 8, 2024
@prafulkoppalkar prafulkoppalkar merged commit f6a945c into main May 10, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the phone-number-validations branch May 10, 2024 16:02
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 10, 2024
akash-c-k pushed a commit that referenced this pull request May 10, 2024
# [0.51.0](v0.50.14...v0.51.0) (2024-05-10)

### Features

* phone country dropdown added ([#270](#270)) ([f6a945c](f6a945c))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
# [0.51.0](juspay/hyperswitch-web@v0.50.14...v0.51.0) (2024-05-10)

### Features

* phone country dropdown added ([#270](juspay/hyperswitch-web#270)) ([f6a945c](juspay/hyperswitch-web@f6a945c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone Number field has bug
5 participants