Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: moved Card Number, Cvc and Expiry to Dynamic Fields for Card Payment method #282

Merged
merged 2 commits into from
May 6, 2024
Merged

refactor: moved Card Number, Cvc and Expiry to Dynamic Fields for Card Payment method #282

merged 2 commits into from
May 6, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

@ArushKapoorJuspay ArushKapoorJuspay commented Apr 8, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Moved Card Number, Card CVC and Card Expiry Fields to Dynamic Fields

How did you test it?

  1. Tested Saved Cards Flow
  2. Tested Cards With Dynamic Fields
  3. Tested Cards in fallback scenarios

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@ArushKapoorJuspay ArushKapoorJuspay changed the title refactor: moved Card Number, Cvc and Expiry to Dynamic Fields for Car… refactor: moved Card Number, Cvc and Expiry to Dynamic Fields for Card Payment method Apr 8, 2024
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Apr 15, 2024
@prafulkoppalkar prafulkoppalkar merged commit abe9d6e into main May 6, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the refactor/dynamic-fields-card branch May 6, 2024 08:40
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 6, 2024
ArushKapoorJuspay pushed a commit that referenced this pull request Sep 23, 2024
@prafulkoppalkar
Pull request #282: added script logic to push to sandbox v0 s3 bucket
ced2a12 
Merge in EXC/orca-elements from main-oss-script-changes to main-oss

* commit '654bfa5c407e0987a2eb33f6a798fd3da8cbaab0':
  added script logic to push to sandbox v0 s3 bucket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prafulkoppalkar prafulkoppalkar prafulkoppalkar approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArushKapoorJuspay @PritishBudhiraja @prafulkoppalkar