Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compressed theme layout #320

Merged
merged 14 commits into from
May 2, 2024
Merged

feat: compressed theme layout #320

merged 14 commits into from
May 2, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added a new layout for compressed view. Merchants wanted to configure compressed layout for better space utilisation.

image

How did you test it?

We can pass one prop in HyperElement options -

<HyperElements
  hyper={hyperPromise}
  options={{
   clientSecret,
   appearance: {
     labels: "floating",
     innerLayout: "compressed", //  "spaced" (default)
   },
}}
>
  <CheckoutForm />
</HyperElements>

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Development In Progress Use this label if you have raised the PR but development is still under progress label Apr 23, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Apr 23, 2024
@github-actions github-actions bot added the S-conventions-not-followed Some Github conventions not followed label Apr 23, 2024
@PritishBudhiraja PritishBudhiraja changed the title Compressed theme layout feat: compressed theme layout Apr 23, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Some Github conventions not followed label Apr 23, 2024
@PritishBudhiraja PritishBudhiraja linked an issue Apr 24, 2024 that may be closed by this pull request
Compressed theme layout #326
Closed
@PritishBudhiraja PritishBudhiraja mentioned this pull request Apr 24, 2024
Closed
@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. and removed Development In Progress Use this label if you have raised the PR but development is still under progress labels Apr 24, 2024
vsrivatsa-edinburgh
vsrivatsa-edinburgh requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@vsrivatsa-edinburgh vsrivatsa-edinburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended changes are made

@akash-c-k akash-c-k merged commit bdc1336 into main May 2, 2024
3 checks passed
@akash-c-k akash-c-k deleted the compressed-theme-layout branch May 2, 2024 12:39
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 2, 2024
akash-c-k pushed a commit that referenced this pull request May 2, 2024
@semantic-release-bot
chore(release): 0.48.0 [skip ci]
a3dd5a1 
# [0.48.0](v0.47.1...v0.48.0) (2024-05-02)

### Features

* compressed theme layout ([#320](#320)) ([bdc1336](bdc1336))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.48.0 [skip ci]
75cdf8a 
# [0.48.0](juspay/hyperswitch-web@v0.47.1...v0.48.0) (2024-05-02)

### Features

* compressed theme layout ([#320](juspay/hyperswitch-web#320)) ([bdc1336](juspay/hyperswitch-web@bdc1336))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsrivatsa-edinburgh vsrivatsa-edinburgh vsrivatsa-edinburgh approved these changes

@akash-c-k akash-c-k akash-c-k approved these changes

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay approved these changes

@vsrivatsa25 vsrivatsa25 vsrivatsa25 approved these changes

@prafulkoppalkar prafulkoppalkar Awaiting requested review from prafulkoppalkar

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compressed theme layout
6 participants
@PritishBudhiraja @vsrivatsa25 @ArushKapoorJuspay @akash-c-k @vsrivatsa-edinburgh @semantic-release-bot