Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: locally connect documentation #335

Merged
merged 18 commits into from
May 6, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added .env file for connecting locally for our backend services and client url changes.

How did you test it?

Run the backend locally and add the required keys for the same to test setuo works as expected or not.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Vrishab Srivatsa and others added 7 commits April 24, 2024 19:38
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Apr 26, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Apr 26, 2024
Copy link
Member

@lsampras lsampras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing environment variable based configuration completely and just relying on the .env file would be a backwards incompatible change.

can use the .env file to complement the environment variables instead.

if we wanna just rely on file based config using a separate .yaml / .json/ .toml file would be a better norm... (instead of .env files)

webpack.common.js Outdated Show resolved Hide resolved
webpack.dev.js Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@prafulkoppalkar prafulkoppalkar merged commit 8582e7f into main May 6, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the locally-connect-documentation branch May 6, 2024 08:58
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main Ready for Review PR with label Ready for Review should only be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation about setting up sdk locally
7 participants