-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unsupported card networks validation #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…browser user agents for logging
…supported_card_networks
…supported_card_networks
vsrivatsa-edinburgh
requested review from
prafulkoppalkar,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
May 15, 2024 08:56
github-actions
bot
added
the
S-conventions-not-followed
Some Github conventions not followed
label
May 15, 2024
vsrivatsa-edinburgh
force-pushed
the
feat/unsupported_card_networks
branch
from
May 15, 2024 08:59
89d8bd0
to
b2b4079
Compare
vsrivatsa-edinburgh
force-pushed
the
feat/unsupported_card_networks
branch
from
May 15, 2024 09:00
b2b4079
to
89d8bd0
Compare
vsrivatsa-edinburgh
changed the title
Feat/unsupported card networks
feat: unsupported card networks validation
May 15, 2024
github-actions
bot
added
S-conventions-not-followed
Some Github conventions not followed
and removed
S-conventions-not-followed
Some Github conventions not followed
labels
May 15, 2024
vsrivatsa-edinburgh
removed
the
S-conventions-not-followed
Some Github conventions not followed
label
May 15, 2024
PritishBudhiraja
added
the
Ready for Review
PR with label Ready for Review should only be reviewed.
label
May 16, 2024
…supported_card_networks
prafulkoppalkar
approved these changes
May 23, 2024
looks good @preetamrevankar can we test this flow properly before we move this to prod |
PritishBudhiraja
approved these changes
May 23, 2024
sakksham7
approved these changes
May 23, 2024
github-actions
bot
added
the
Closed
Label will be automatically added when the PR will get merged to main
label
May 23, 2024
akash-c-k
pushed a commit
that referenced
this pull request
May 23, 2024
# [0.55.0](v0.54.2...v0.55.0) (2024-05-23) ### Features * unsupported card networks validation ([#370](#370)) ([05f527a](05f527a))
rising-dragon401
added a commit
to rising-dragon401/hyperswitch-web
that referenced
this pull request
Jul 2, 2024
# [0.55.0](juspay/hyperswitch-web@v0.54.2...v0.55.0) (2024-05-23) ### Features * unsupported card networks validation ([#370](juspay/hyperswitch-web#370)) ([05f527a](juspay/hyperswitch-web@05f527a))
PritishBudhiraja
removed
the
Ready for Review
PR with label Ready for Review should only be reviewed.
label
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Consistent validation UX for card network check
How did you test it?
Checklist
npm run re:build