Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unsupported card networks validation #370

Merged
merged 15 commits into from
May 23, 2024

Conversation

vsrivatsa-edinburgh
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Consistent validation UX for card network check

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@vsrivatsa-edinburgh vsrivatsa-edinburgh changed the title Feat/unsupported card networks feat: unsupported card networks validation May 15, 2024
@github-actions github-actions bot added S-conventions-not-followed Some Github conventions not followed and removed S-conventions-not-followed Some Github conventions not followed labels May 15, 2024
src/Payment.res Outdated Show resolved Hide resolved
@vsrivatsa-edinburgh vsrivatsa-edinburgh removed the S-conventions-not-followed Some Github conventions not followed label May 15, 2024
src/Payment.res Outdated Show resolved Hide resolved
src/Payment.res Outdated Show resolved Hide resolved
src/Payment.res Outdated Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label May 16, 2024
@PritishBudhiraja PritishBudhiraja linked an issue May 21, 2024 that may be closed by this pull request
@prafulkoppalkar
Copy link
Contributor

looks good @preetamrevankar can we test this flow properly before we move this to prod

@prafulkoppalkar prafulkoppalkar merged commit 05f527a into main May 23, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the feat/unsupported_card_networks branch May 23, 2024 11:00
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 23, 2024
akash-c-k pushed a commit that referenced this pull request May 23, 2024
# [0.55.0](v0.54.2...v0.55.0) (2024-05-23)

### Features

* unsupported card networks validation ([#370](#370)) ([05f527a](05f527a))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
# [0.55.0](juspay/hyperswitch-web@v0.54.2...v0.55.0) (2024-05-23)

### Features

* unsupported card networks validation ([#370](juspay/hyperswitch-web#370)) ([05f527a](juspay/hyperswitch-web@05f527a))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card validation enhancement from SDK
5 participants