Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added Fixes for one click widgets #399

Merged
merged 3 commits into from
May 27, 2024
Merged

fix: added Fixes for one click widgets #399

merged 3 commits into from
May 27, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixed the following bugs for one click widgets -

  1. Renamed PaymentRequestButtonsElement to ExpressCheckoutElement
  2. Incorrect x-client-source in the confirm call
  3. GooglePay not collecting shipping details when the last widget added is PaymentElement
  4. ApplePay only rendering once when using multiple widgets
  5. In case GooglePay and ApplePay being loaded in separate widgets, confirm call only working for the last loaded widget
  6. Shipping Details not getting collected in case the last loaded widget is PaymentElement

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

prafulkoppalkar
prafulkoppalkar approved these changes May 27, 2024
View reviewed changes
src/Types/ApplePayTypes.res Show resolved Hide resolved
src/orca-loader/Types.res Show resolved Hide resolved
@prafulkoppalkar prafulkoppalkar self-requested a review May 27, 2024 06:50
prafulkoppalkar
prafulkoppalkar suggested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@prafulkoppalkar prafulkoppalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label May 27, 2024
@prafulkoppalkar prafulkoppalkar merged commit a1a1c5e into main May 27, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix/one-click-widgets branch May 27, 2024 09:44
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 27, 2024
akash-c-k pushed a commit that referenced this pull request May 27, 2024
@semantic-release-bot
chore(release): 0.56.0 [skip ci]
b5961de 
# [0.56.0](v0.55.2...v0.56.0) (2024-05-27)

### Bug Fixes

* added Fixes for one click widgets ([#399](#399)) ([a1a1c5e](a1a1c5e))

### Features

* 3DS netcetra Part B ([#383](#383)) ([aa44b98](aa44b98))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.56.0 [skip ci]
e59ed6c 
# [0.56.0](juspay/hyperswitch-web@v0.55.2...v0.56.0) (2024-05-27)

### Bug Fixes

* added Fixes for one click widgets ([#399](juspay/hyperswitch-web#399)) ([a1a1c5e](juspay/hyperswitch-web@a1a1c5e))

### Features

* 3DS netcetra Part B ([#383](juspay/hyperswitch-web#383)) ([aa44b98](juspay/hyperswitch-web@aa44b98))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@prafulkoppalkar prafulkoppalkar prafulkoppalkar approved these changes

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArushKapoorJuspay @PritishBudhiraja @prafulkoppalkar