Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdk button loader issue #400

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: sdk button loader issue #400

merged 1 commit into from
May 27, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Loader was not getting stopped in case of failed payments

How did you test it?

Via making a failed and a succesfull payment

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label May 27, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this May 27, 2024
@prafulkoppalkar prafulkoppalkar merged commit e012642 into main May 27, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix-loader-sdk-issue branch May 27, 2024 08:46
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 27, 2024
akash-c-k pushed a commit that referenced this pull request May 27, 2024
@semantic-release-bot
chore(release): 0.55.1 [skip ci]
a041c04 
## [0.55.1](v0.55.0...v0.55.1) (2024-05-27)

### Bug Fixes

* sdk button loader issue ([#400](#400)) ([e012642](e012642))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.55.1 [skip ci]
763724e 
## [0.55.1](juspay/hyperswitch-web@v0.55.0...v0.55.1) (2024-05-27)

### Bug Fixes

* sdk button loader issue ([#400](juspay/hyperswitch-web#400)) ([e012642](juspay/hyperswitch-web@e012642))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prafulkoppalkar prafulkoppalkar prafulkoppalkar approved these changes

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay approved these changes

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PritishBudhiraja @ArushKapoorJuspay @prafulkoppalkar