Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed fallback in case of sessions call fail based on payment experience #440

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: removed fallback in case of sessions call fail based on payment experience #440

merged 1 commit into from
Jun 13, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Removed Klarna Fallback in case of sessions call fail based on payment experience

How did you test it?

  1. When payment experience is invoke_sdk_client
    • Sessions Call contains Klarna - Klarna SDK should be rendered
    • Sessions Call does not contain Klarna - Klarna SDK should not be rendered
  2. When payment experience is redirect_to_url
    • Sessions Call contains Klarna - Klarna Redirect should be rendered (in tabs)
    • Sessions Call does not contain Klarna - Klarna Redirect should be rendered (in tabs)
  3. When payment experience is invoke_sdk_client and redirect_to_url
    • Sessions Call contains Klarna - Klarna SDK should be rendered
    • Sessions Call does not contain Klarna - Klarna Redirect should be rendered (in tabs)

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@ArushKapoorJuspay ArushKapoorJuspay self-assigned this Jun 12, 2024
@prafulkoppalkar prafulkoppalkar merged commit 8f2e408 into main Jun 13, 2024
3 checks passed
@prafulkoppalkar prafulkoppalkar deleted the fix/klarna-fallback branch June 13, 2024 08:36
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Jun 13, 2024
akash-c-k pushed a commit that referenced this pull request Jun 13, 2024
@semantic-release-bot
chore(release): 0.62.3 [skip ci]
9d09b71 
## [0.62.3](v0.62.2...v0.62.3) (2024-06-13)

### Bug Fixes

* removed fallback in case of sessions call fail based on payment experience ([#440](#440)) ([8f2e408](8f2e408))
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
@rising-dragon401
chore(release): 0.62.3 [skip ci]
73fdf10 
## [0.62.3](juspay/hyperswitch-web@v0.62.2...v0.62.3) (2024-06-13)

### Bug Fixes

* removed fallback in case of sessions call fail based on payment experience ([#440](juspay/hyperswitch-web#440)) ([8f2e408](juspay/hyperswitch-web@8f2e408))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@prafulkoppalkar prafulkoppalkar prafulkoppalkar approved these changes

@PritishBudhiraja PritishBudhiraja Awaiting requested review from PritishBudhiraja PritishBudhiraja is a code owner

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArushKapoorJuspay @SamraatBansal @prafulkoppalkar