feat: language preference for mifinity added #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakksham7
requested review from
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay and
vsrivatsa-edinburgh
as code owners
PritishBudhiraja
added
the
Ready for Review
seekshiva
requested changes
Jul 17, 2024
seekshiva
approved these changes
Jul 17, 2024
github-actions
bot
added
the
Closed
akash-c-k
pushed a commit
that referenced
this pull request
Jul 17, 2024
# [0.76.0](v0.75.0...v0.76.0) (2024-07-17) ### Features * language preference for mifinity added ([#502](#502)) ([f9f15ca](f9f15ca))
PritishBudhiraja
removed
the
Ready for Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added language preference for mifinity
if the language passed by merchant is supported by mifinity then we pass it as same, else if the language passed is auto then we take language from browser, else we pass "en".
How did you test it?
tested by firstly passing supported language locale , the sdk was rendered in the provided language, then passed the locale as "auto", the sdk rendered in browser specified language, then passed an unsupported and empty locale, in this case the english language was shown.
Checklist
npm run re:build