Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pix confirm call and added locale support #528

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fixed confirm call not happening in Pix and added locale support for Pix along with additional chinese locale

How did you test it?

configured pix connector and rendered sdk using the respective api keys, also tested by sending different locale in payment.js

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label Jul 29, 2024
@sakksham7 sakksham7 self-assigned this Jul 29, 2024
@sakksham7 sakksham7 linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PritishBudhiraja PritishBudhiraja merged commit 382e1c1 into main Jul 30, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the pix-locale branch July 30, 2024 07:10
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Jul 30, 2024
akash-c-k pushed a commit that referenced this pull request Jul 30, 2024
## [0.78.1](v0.78.0...v0.78.1) (2024-07-30)

### Bug Fixes

* pix confirm call and added locale support ([#528](#528)) ([382e1c1](382e1c1))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add locale support for multiple more languages
2 participants