refactor(routing): remove payment_id from dynamic_routing metrics (#6535

)
juspay · Nov 12, 2024 · c484beb · c484beb
1 parent 548d1b0
commit c484beb
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/crates/router/src/core/routing/helpers.rs b/crates/router/src/core/routing/helpers.rs
@@ -733,7 +733,7 @@ pub async fn push_metrics_with_update_window_for_success_based_routing(
             .label
             .to_string();
 
-        let (first_success_based_connector, merchant_connector_id) = first_success_based_connector_label
+        let (first_success_based_connector, _) = first_success_based_connector_label
             .split_once(':')
             .ok_or(errors::ApiErrorResponse::InternalServerError)
             .attach_printable(format!(
@@ -753,17 +753,12 @@ pub async fn push_metrics_with_update_window_for_success_based_routing(
             &add_attributes([
                 ("tenant", state.tenant.tenant_id.clone()),
                 (
-                    "merchant_id",
-                    payment_attempt.merchant_id.get_string_repr().to_string(),
-                ),
-                (
-                    "profile_id",
-                    payment_attempt.profile_id.get_string_repr().to_string(),
-                ),
-                ("merchant_connector_id", merchant_connector_id.to_string()),
-                (
-                    "payment_id",
-                    payment_attempt.payment_id.get_string_repr().to_string(),
+                    "merchant_profile_id",
+                    format!(
+                        "{}:{}",
+                        payment_attempt.merchant_id.get_string_repr(),
+                        payment_attempt.profile_id.get_string_repr()
+                    ),
                 ),
                 (
                     "success_based_routing_connector",