feat(connector): [RISKIFIED] Add support for riskified frm connector #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshayaFoiger
added
A-dependencies
github-actions
bot
added
the
S-conventions-not-followed
AkshayaFoiger
changed the title
AkshayaFoiger
removed
the
S-conventions-not-followed
github-actions
bot
added
the
S-conventions-not-followed
AkshayaFoiger
changed the title
AkshayaFoiger
removed
the
S-conventions-not-followed
github-actions
bot
added
the
S-conventions-not-followed
AkshayaFoiger
changed the title
AkshayaFoiger
changed the title
AkshayaFoiger
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
jagan-jaya
requested changes
Oct 11, 2023
SanchithHegde
dismissed stale reviews from kashif-m and jagan-jaya
The base branch was changed.
AkshayaFoiger
force-pushed
the
riskified
branch
from
faaad3a
to
9c1c44a
Compare
kashif-m
reviewed
Dec 7, 2023
crates/router_env/Cargo.toml
Outdated
| actix_web = ["tracing-actix-web"] | ||
| log_custom_entries_to_extra = [] | ||
| log_extra_implicit_fields = [] | ||
| log_active_span_json = [] | ||
| payouts = [] | ||
| frm = [] |
There was a problem hiding this comment.
We don't need the feature in this crate. This can be removed
kashif-m
reviewed
Dec 7, 2023
| @@ -175,7 +172,7 @@ impl From<SignifydPaymentStatus> for storage_enums::FraudCheckStatus { | |||
| SignifydPaymentStatus::Accept => Self::Legit, | |||
| SignifydPaymentStatus::Reject => Self::Fraud, | |||
| SignifydPaymentStatus::Hold => Self::ManualReview, | |||
| SignifydPaymentStatus::Challenge | SignifydPaymentStatus::Credit => Self::Pending, | |||
| SignifydPaymentStatus::Credit | SignifydPaymentStatus::Challenge => Self::Pending, | |||
There was a problem hiding this comment.
There's no change here, this can be reverted
kashif-m
previously approved these changes
Dec 7, 2023
jagan-jaya
previously approved these changes
Dec 11, 2023
AkshayaFoiger
dismissed stale reviews from jagan-jaya and kashif-m
via
48ed336
kashif-m
approved these changes
Dec 12, 2023
jagan-jaya
approved these changes
Dec 12, 2023
SanchithHegde
approved these changes
Dec 12, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add support for Riskified FRM Connector.
This PR resolves the problem mentioned in issue #2453.
Test Cases
1.Create a Merchant Account with frm enabled
2.Create an API key
3.Create a Stripe MCA
4.Create a Riskified MCA
5.Create a payment. The response should have frm data populated
6.Create a fullfillment call with the order id
Checklist
cargo +nightly fmt --allcargo clippy