Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment_methods): add support for tokenising bank details and fetching masked details while listing #2585

Merged
merged 26 commits into from
Nov 22, 2023

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented Oct 14, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes changes for tokenising the fetched bank details and return masked bank details while fetching the customer payment methods

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

List customer payment method -

image

Redis Entry -

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Oct 14, 2023
@Chethan-rao Chethan-rao added this to the October 2023 Milestone milestone Oct 14, 2023
@Chethan-rao Chethan-rao self-assigned this Oct 14, 2023
@Chethan-rao Chethan-rao requested review from a team, jarnura and ashokkjag as code owners October 14, 2023 12:17
@Chethan-rao Chethan-rao force-pushed the support_for_bank_in_customer_pm_list branch 2 times, most recently from 4399892 to 500405d Compare October 14, 2023 12:29
@Chethan-rao Chethan-rao changed the base branch from locker-id-as-hyps-token-for-cards to main October 14, 2023 12:32
@Chethan-rao Chethan-rao marked this pull request as draft October 14, 2023 12:32
@Chethan-rao Chethan-rao force-pushed the support_for_bank_in_customer_pm_list branch from 6be714d to 3065bb7 Compare October 15, 2023 08:48
@Chethan-rao Chethan-rao marked this pull request as ready for review October 19, 2023 10:46
@Chethan-rao Chethan-rao marked this pull request as draft October 25, 2023 10:34
@Chethan-rao Chethan-rao changed the title feat(payment_methods): add support for tokenizing bank details and fetching masked details while listing feat(payment_methods): add support for tokenising bank details and fetching masked details while listing Oct 25, 2023
Base automatically changed from locker-id-as-hyps-token-for-cards to main November 20, 2023 11:00
@Chethan-rao Chethan-rao marked this pull request as ready for review November 22, 2023 10:29
@Chethan-rao Chethan-rao requested a review from vspecky November 22, 2023 10:40
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 9989489 Nov 22, 2023
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the support_for_bank_in_customer_pm_list branch November 22, 2023 11:59
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for tokenising bank details and fetching masked details while listing
6 participants