-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): [Paypal] Add support for both BodyKey and SignatureKey #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Oct 18, 2023
swangi-kumari
changed the title
Paypal auth
refactor(connector): [Paypal] Add support for both BodyKey and SignatureKey
Nov 3, 2023
github-actions
bot
removed
the
S-conventions-not-followed
Status: This PR does not follow contributing guidelines
label
Nov 3, 2023
swangi-kumari
added
A-connector-integration
Area: Connector integration
C-refactor
Category: Refactor
labels
Nov 3, 2023
ArjunKarthik
requested changes
Nov 21, 2023
ArjunKarthik
previously approved these changes
Nov 21, 2023
2 tasks
ArjunKarthik
approved these changes
Nov 21, 2023
apoorvdixit88
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
SignatureKey
auth_type
.orders
request.Additional Changes
Motivation and Context
To support PayPal onboarding flow.
How did you test it?
Postman.
Payment Connector - Create
Paypal now supports
TemporaryAuth
in theauth_type
. You can find more details about this in this PR #2833.Paypal also support
SignatureKey
in theauth_type
.If all the fields are passed correctly you will a normal mca response.
Checklist
cargo +nightly fmt --all
cargo clippy