-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: insert merchant account and merchant key store in a db transaction #2663
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
.await | ||
.map_err(Into::into) | ||
.into_report()? | ||
.convert(merchant_key_store.key.get_inner()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be self.get_master_key()
Signed-off-by: Azanul <azanulhaque@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the PR, @Azanul!
@Azanul Could you please address the failing CI checks? |
@Azanul can you please resolve the compilation errors, Other than that LGTM |
@dracarys18 @SanchithHegde How do I fix this? |
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
You are returning |
How? |
into_report() converts error to Report instead of that you can use .map_err(err| err.current_context()) |
Hey @Azanul , |
I'm looking forward to contributing to hyperswitch even after Hacktoberfest. Regarding the current PR, I don't think I understand the codebase enough or I'm not that good with Rust yet to see this through. Although I keep trying to do so. |
Type of Change
Description
Merchant account creation and respective key store creation now happen in a DB transaction
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy