Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Stax] Currency Unit Conversion #2711

Merged
merged 35 commits into from
Nov 5, 2023
Merged

refactor(connector): [Stax] Currency Unit Conversion #2711

merged 35 commits into from
Nov 5, 2023

Conversation

shivansh-bhatnagar18
Copy link
Contributor

@shivansh-bhatnagar18 shivansh-bhatnagar18 commented Oct 27, 2023 •
edited by deepanshu-iiitu
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR solves the Currency Unit Conversion for STAX Connector and fixes issue #2246

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

We need to create a payment using Stax and test the currency unit from connector response and connector dashboard.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

shivanshbhatnagar18 and others added 20 commits October 23, 2023 00:43
@shivanshbhatnagar18
refactor(connector): [Rapyd]added the get_currency_unit modification
b96ec3b
@shivanshbhatnagar18
Merge branch 'main' of https://github.com/shivansh-bhatnagar18/hypers…
514c18c 
…witch
@shivanshbhatnagar18
Some Minor Fixes on Formatting and Typos
ea100cf
@shivansh-bhatnagar18
Merge branch 'main' into main
ccc2a89
@shivansh-bhatnagar18
Merge branch 'juspay:main' into main
5c805ab
@shivanshbhatnagar18
Fixed some errors
e77ac09
@shivanshbhatnagar18
Merge branch 'main' of https://github.com/shivansh-bhatnagar18/hypers…
916e988 
…witch
@shivanshbhatnagar18
replaced items.amount after changes in rapyd.rs
df2df61
@shivanshbhatnagar18
Done with the Capture Tryfrom changes
4f2d4ae
@shivanshbhatnagar18
Some minor fixes
61453c4
@shivansh-bhatnagar18
Merge branch 'juspay:main' into main
4dd1ce6
@shivanshbhatnagar18
Changed the Rapyd Currency Handling Format
622094d
@shivansh-bhatnagar18
Merge branch 'juspay:main' into main
0a6dd88
@shivanshbhatnagar18
Minor Fixes
de692d2
@shivanshbhatnagar18
Merge branch 'main' of https://github.com/shivansh-bhatnagar18/hypers…
0836b06 
…witch
@shivanshbhatnagar18
Fixes
495af26
@shivanshbhatnagar18
Fixes the errors
1bacffd
@shivansh-bhatnagar18
Merge branch 'juspay:main' into main
c147eff
@shivansh-bhatnagar18
Merge branch 'juspay:main' into main
18b741c
@shivanshbhatnagar18
Added Currency Conversion Unit for Stax
0cf9ad6
@shivansh-bhatnagar18 shivansh-bhatnagar18 requested a review from a team as a code owner October 27, 2023 14:45
@swangi-kumari
Copy link
Contributor

Hey @shivansh-bhatnagar18 ,
Have you addressed lints thrown by cargo clippy?

@shivansh-bhatnagar18
Copy link
Contributor Author

No, will do it ASAP

@swangi-kumari swangi-kumari linked an issue Oct 29, 2023 that may be closed by this pull request
[FEATURE]: [Stax] Currency Unit Conversion #2246
Closed
2 tasks
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 29, 2023
@deepanshu-iiitu
Copy link
Contributor

deepanshu-iiitu commented Oct 31, 2023 •
edited by swangi-kumari
Loading

Hi @shivansh-bhatnagar18
Please address the CI checks compilation errors.

Also use the following commands before committing your code

Run cargo +nightly fmt for formatting.
Run cargo clippy and addressed lints thrown by it.

AkshayaFoiger
AkshayaFoiger requested changes Oct 31, 2023
View reviewed changes
crates/router/src/connector/stax/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/stax/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/stax/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/stax/transformers.rs Outdated Show resolved Hide resolved
swangi-kumari
swangi-kumari approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@swangi-kumari swangi-kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shivansh-bhatnagar18
Copy link
Contributor Author

@deepanshu-iiitu @SamraatBansal @srujanchikke Can you also please review my changes and merge my pull request?

@AkshayaFoiger
Copy link
Contributor

Hello @shivansh-bhatnagar18 ,
your PR is approved. It will get merged by Monday.

SanchithHegde
SanchithHegde approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @shivansh-bhatnagar18!

@SanchithHegde SanchithHegde added this pull request to the merge queue Nov 5, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-ready-for-merge labels Nov 5, 2023
Merged via the queue into juspay:main with commit 2782923 Nov 5, 2023
11 checks passed
@deepanshu-iiitu
Copy link
Contributor

Hey @shivansh-bhatnagar18 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkshayaFoiger AkshayaFoiger AkshayaFoiger approved these changes

@swangi-kumari swangi-kumari swangi-kumari approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@SamraatBansal SamraatBansal Awaiting requested review from SamraatBansal

@deepanshu-iiitu deepanshu-iiitu Awaiting requested review from deepanshu-iiitu

@srujanchikke srujanchikke Awaiting requested review from srujanchikke

Assignees

@shivansh-bhatnagar18 shivansh-bhatnagar18

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Stax] Currency Unit Conversion
6 participants
@shivansh-bhatnagar18 @swangi-kumari @deepanshu-iiitu @AkshayaFoiger @SanchithHegde @shivanshbhatnagar18