feat: add support for 3ds and surcharge decision through routing rules #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
previously approved these changes
Nov 17, 2023
jarnura
reviewed
Nov 20, 2023
crates/router/src/core/payments.rs
Outdated
| use super::{ | ||
| errors::StorageErrorExt, | ||
| payment_methods::surcharge_decision_configs::perform_surcharge_decision_management_for_session_flow, | ||
| utils::persist_individual_surcharge_details_in_redis, |
There was a problem hiding this comment.
Remove here and add self in utils and use utils::fn directly, for payment_method also follow the same method.
vspecky
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Overall LGTM.
@hrithikesh026 Please test the surcharge flow in this PR once
@Aprabhat19 Please test the 3DS decision manager flow in this PR once.
Aprabhat19
previously approved these changes
Nov 21, 2023
Tested surcharge feature and found out the surcharge was getting updated in DB from confirm request. Fixed it. Everything else works fine. |
Narayanbhat166
approved these changes
Nov 21, 2023
vspecky
approved these changes
Nov 21, 2023
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
added support for deriving 3ds and surcharge decisions through routing rules set by merchant.
Additional Changes
Motivation and Context
How did you test it?
Steps to test : https://github.com/juspay/hyperswitch-cloud/issues/2731#issuecomment-1770147086
To test 3DS,
authentication_typefield and verify that payment goes through3dsorno 3dsaccording to the rule.Checklist
cargo +nightly fmt --allcargo clippy