feat(connector): [BANKOFAMERICA] Implement Google Pay #2940

deepanshu-iiitu · 2023-11-21T15:48:10Z

Type of Change

Description

Implement Payment Method Google Pay for connector Bankofamerica

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/3297

How did you test it?

Authorize(Manual+Automatic), Capture and PSYNC flow needs to be tested for Payment Method Google Pay for connector Bankofamerica

curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: API_KEY_HERE' \
--data-raw '{
    
    
    "amount": 900,
    "currency": "USD",
    "confirm": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    
    "customer_id": "CustomerX",
    "email": "guest@example.com",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+1",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "payment_method": "wallet",
    "payment_method_type": "google_pay",
    "payment_method_data": {
        "wallet": {
            "google_pay": {
                "type": "CARD",
                "description": "Visa •••• 1111",
                "info": {
                    "card_network": "VISA",
                    "card_details": "1111"
                },
                "tokenization_data": {
                    "type": "PAYMENT_GATEWAY",
                    "token": "GOOGLE_PAY_TOKEN_HERE"
                }
            }
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "Dubai",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+97"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "AE",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "business_label": "food",
    "business_country": "US"
}'

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

ArjunKarthik · 2023-11-22T06:53:35Z

crates/router/src/connector/bankofamerica/transformers.rs

 pub struct PaymentInformation {
-    card: Card,
+    card: Option<Card>,


Create enum for PaymentInformation, one for card and one for fluid data

ArjunKarthik · 2023-11-22T06:54:09Z

crates/router/src/connector/bankofamerica/transformers.rs

+        let email = item.router_data.request.get_email()?;
+        let bill_to = build_bill_to(item.router_data.get_billing()?, email)?;
+
+        let order_information = OrderInformationWithBill {


Handle this with From impl so redundant code can be reduced

ArjunKarthik · 2023-11-22T06:55:03Z

crates/router/src/connector/bankofamerica/transformers.rs

+            fluid_data: None,
+        };
+
+        let processing_information = ProcessingInformation {


Use From implementation

ArjunKarthik · 2023-11-22T06:55:56Z

crates/router/src/connector/bankofamerica/transformers.rs

+            payment_solution: None,
+        };
+
+        let client_reference_information = ClientReferenceInformation {


Please use From impl

ArjunKarthik · 2023-11-22T09:15:39Z

crates/router/src/connector/bankofamerica/transformers.rs

+            },
+        });
+
+        let payment_solution = Some("012".to_string());


Let's have this as enum, which will be useful while implementing applepay

ArjunKarthik · 2023-11-22T09:16:08Z

crates/router/src/connector/bankofamerica/transformers.rs

+        value: (
+            &BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,
+            payments::GooglePayWalletData,
+        ),


Suggested change

value: (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

payments::GooglePayWalletData,

),

(item, google_pay_data): (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

payments::GooglePayWalletData,

),

ArjunKarthik · 2023-11-22T09:16:34Z

crates/router/src/connector/bankofamerica/transformers.rs

+        value: (
+            &BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,
+            payments::Card,
+        ),


Suggested change

value: (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

payments::Card,

),

(item, ccard): (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

payments::Card,

),

ArjunKarthik · 2023-11-22T09:16:50Z

crates/router/src/connector/bankofamerica/transformers.rs

+        value: (
+            &BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,
+            Option<String>,
+        ),


Suggested change

value: (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

Option<String>,

),

(item, payment_solution): (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

Option<String>,

),

ArjunKarthik · 2023-11-22T09:17:06Z

crates/router/src/connector/bankofamerica/transformers.rs

+        value: (
+            &BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,
+            BillTo,
+        ),


Suggested change

value: (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

BillTo,

),

(item, bill_to): (

&BankOfAmericaRouterData<&types::PaymentsAuthorizeRouterData>,

BillTo,

),

feat(connector): [BANKOFAMERICA] Implement Google Pay

13c8d79

deepanshu-iiitu requested a review from a team as a code owner November 21, 2023 15:48

deepanshu-iiitu self-assigned this Nov 21, 2023

deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Nov 21, 2023

feat(connector): [BANKOFAMERICA] Add BASE64 Encoding

e54a92b

deepanshu-iiitu requested a review from ArjunKarthik November 21, 2023 16:43

ArjunKarthik requested changes Nov 22, 2023

View reviewed changes

ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Nov 22, 2023

feat(connector): [BANKOFAMERICA] Resolve PR comments

184e1f5

deepanshu-iiitu requested a review from ArjunKarthik November 22, 2023 09:09

deepanshu-iiitu added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 22, 2023

ArjunKarthik requested changes Nov 22, 2023

View reviewed changes

deepanshu-iiitu added 2 commits November 22, 2023 16:09

feat(connector): [BANKOFAMERICA] Resolve PR Comments PART2

3480b66

chore: Address lints thrown by clippy

3475e17

deepanshu-iiitu requested a review from ArjunKarthik November 22, 2023 10:49

ArjunKarthik approved these changes Nov 22, 2023

View reviewed changes

deepanshu-iiitu requested a review from SamraatBansal November 22, 2023 10:55

SamraatBansal approved these changes Nov 22, 2023

View reviewed changes

deepanshu-iiitu added 5 commits November 22, 2023 16:30

Merge branch 'main' into boa_gpay

3414ebb

Merge branch 'main' into boa_gpay

bfa0335

Merge branch 'main' into boa_gpay

62e686e

Merge branch 'main' into boa_gpay

f9603b5

Merge branch 'main' into boa_gpay

1847743

Gnanasundari24 approved these changes Nov 22, 2023

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Nov 22, 2023

Merged via the queue into main with commit f91d4ae Nov 22, 2023
10 of 12 checks passed

Gnanasundari24 deleted the boa_gpay branch November 22, 2023 16:49

SanchithHegde added C-feature Category: Feature request or enhancement and removed C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 27, 2023

deepanshu-iiitu added a commit that referenced this pull request Dec 20, 2023

feat(connector): [BANKOFAMERICA] Implement Google Pay (#2940)

e363c2e

deepanshu-iiitu mentioned this pull request Dec 20, 2023

feat(connector): [BOA] Add GPAY, ApplePay and other fixes #3174

Merged

15 tasks

deepanshu-iiitu added a commit that referenced this pull request Dec 20, 2023

feat(connector): [BANKOFAMERICA] Implement Google Pay (#2940)

8dd380a

deepanshu-iiitu mentioned this pull request Dec 20, 2023

feat(connector): [BOA] Add GPAY, ApplePay and other fixes #3180

Closed

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [BANKOFAMERICA] Implement Google Pay #2940

feat(connector): [BANKOFAMERICA] Implement Google Pay #2940

deepanshu-iiitu commented Nov 21, 2023 •

edited

Loading

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

ArjunKarthik Nov 22, 2023

deepanshu-iiitu Nov 22, 2023

feat(connector): [BANKOFAMERICA] Implement Google Pay #2940

feat(connector): [BANKOFAMERICA] Implement Google Pay #2940

Conversation

deepanshu-iiitu commented Nov 21, 2023 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepanshu-iiitu commented Nov 21, 2023 •

edited

Loading